aboutsummaryrefslogtreecommitdiff
path: root/drivers/accel/qaic
diff options
context:
space:
mode:
authorGravatar Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com> 2023-09-01 11:22:43 -0600
committerGravatar Jeffrey Hugo <quic_jhugo@quicinc.com> 2023-09-22 09:56:23 -0600
commit77f71e153f09acef574dffc4298eac7822407665 (patch)
tree0fd78d058e1a6b152a52d92cbd39ccb8e3bede6d /drivers/accel/qaic
parentaccel/qaic: Update BO metadata in a central location (diff)
downloadlinux-77f71e153f09acef574dffc4298eac7822407665.tar.gz
linux-77f71e153f09acef574dffc4298eac7822407665.tar.bz2
linux-77f71e153f09acef574dffc4298eac7822407665.zip
accel/qaic: Declare BO 'sliced' after all the operations are complete
Once the BO is declared 'sliced' by setting bo->sliced to true we can perform DMA (QAIC_EXECUTE_BO) operation on that BO. Hence we should declare a BO sliced after completing all the operations. Adding BO to its respective DBC list in qaic_attach_slicing_bo() seems out of place as qaic_attach_slicing_bo() should just update BO with slicing configuration. Signed-off-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230901172247.11410-4-quic_jhugo@quicinc.com
Diffstat (limited to 'drivers/accel/qaic')
-rw-r--r--drivers/accel/qaic/qaic_data.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c
index 710bd355ed8e..6a802497834c 100644
--- a/drivers/accel/qaic/qaic_data.c
+++ b/drivers/accel/qaic/qaic_data.c
@@ -911,9 +911,6 @@ static int qaic_attach_slicing_bo(struct qaic_device *qdev, struct qaic_bo *bo,
return -ENOSPC;
}
- bo->sliced = true;
- list_add_tail(&bo->bo_list, &bo->dbc->bo_lists);
-
return 0;
}
@@ -1015,6 +1012,8 @@ int qaic_attach_slice_bo_ioctl(struct drm_device *dev, void *data, struct drm_fi
if (args->hdr.dir == DMA_TO_DEVICE)
dma_sync_sgtable_for_cpu(&qdev->pdev->dev, bo->sgt, args->hdr.dir);
+ bo->sliced = true;
+ list_add_tail(&bo->bo_list, &bo->dbc->bo_lists);
srcu_read_unlock(&dbc->ch_lock, rcu_id);
drm_gem_object_put(obj);
srcu_read_unlock(&qdev->dev_lock, qdev_rcu_id);