diff options
| author |  Tomer Tayar <ttayar@habana.ai>
| 2024-01-02 16:51:09 +0200 |
|---|---|---|
| committer |  Oded Gabbay <ogabbay@kernel.org>
| 2024-02-26 09:30:40 +0200 |
| commit | 01f8cd0fafa69c95aa67fa316a23977eb5a2cb50 (patch) | |
| tree | 0e70de9e0ce28371cc895a1aec224108576e12fa /drivers/accel | |
| parent | accel/habanalabs: remove call to deprecated function (diff) | |
| download | linux-01f8cd0fafa69c95aa67fa316a23977eb5a2cb50.tar.gz linux-01f8cd0fafa69c95aa67fa316a23977eb5a2cb50.tar.bz2 linux-01f8cd0fafa69c95aa67fa316a23977eb5a2cb50.zip | |
accel/habanalabs/gaudi2: fail memory memset when failing to copy QM packet to device
gaudi2_memset_memory_chunk_using_edma_qm() calls the access_dev_mem()
ASIC function, but ignores its return value.
Add this missing check.
Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Diffstat (limited to 'drivers/accel')
| -rw-r--r-- | drivers/accel/habanalabs/gaudi2/gaudi2.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c index 05e2170c815e..1f061209ae21 100644 --- a/drivers/accel/habanalabs/gaudi2/gaudi2.c +++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c @@ -10345,14 +10345,20 @@ static int gaudi2_memset_memory_chunk_using_edma_qm(struct hl_device *hdev, pkt_size = sizeof(struct packet_lin_dma); - for (i = 0; i < 3; i++) + for (i = 0; i < 3; i++) { rc = hdev->asic_funcs->access_dev_mem(hdev, PCI_REGION_DRAM, phys_addr + (i * sizeof(u64)), ((u64 *)(lin_dma_pkt)) + i, DEBUGFS_WRITE64); + if (rc) { + dev_err(hdev->dev, "Failed to copy lin_dma packet to HBM (%#llx)\n", + phys_addr); + return rc; + } + } rc = hl_hw_queue_send_cb_no_cmpl(hdev, hw_queue_id, pkt_size, phys_addr); if (rc) - dev_err(hdev->dev, "Failed to send lin dma packet to H/W queue %d\n", + dev_err(hdev->dev, "Failed to send lin_dma packet to H/W queue %d\n", hw_queue_id); return rc; |