diff options
| author |  Bart Van Assche <bvanassche@acm.org>
| 2024-05-10 13:23:12 -0700 |
|---|---|---|
| committer |  Jens Axboe <axboe@kernel.dk>
| 2024-05-14 07:22:35 -0600 |
| commit | f6cb9a2c3d2e893a8d493d34ed3e0400fe8afe28 (patch) | |
| tree | 7f82ae9d13598cc742354f9e8e923e6c69ec5eba /drivers/block | |
| parent | nbd: Improve the documentation of the locking assumptions (diff) | |
| download | linux-f6cb9a2c3d2e893a8d493d34ed3e0400fe8afe28.tar.gz linux-f6cb9a2c3d2e893a8d493d34ed3e0400fe8afe28.tar.bz2 linux-f6cb9a2c3d2e893a8d493d34ed3e0400fe8afe28.zip | |
nbd: Remove a local variable from nbd_send_cmd()
blk_rq_bytes() returns an unsigned int while 'size' has type unsigned long.
This is confusing. Improve code readability by removing the local variable
'size'.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Josef Bacik <jbacik@fb.com>
Cc: Yu Kuai <yukuai3@huawei.com>
Cc: Markus Pargmann <mpa@pengutronix.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240510202313.25209-5-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/nbd.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 05f69710afe8..29e43ab1650c 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -597,7 +597,6 @@ static int nbd_send_cmd(struct nbd_device *nbd, struct nbd_cmd *cmd, int index) struct nbd_request request = {.magic = htonl(NBD_REQUEST_MAGIC)}; struct kvec iov = {.iov_base = &request, .iov_len = sizeof(request)}; struct iov_iter from; - unsigned long size = blk_rq_bytes(req); struct bio *bio; u64 handle; u32 type; @@ -646,7 +645,7 @@ static int nbd_send_cmd(struct nbd_device *nbd, struct nbd_cmd *cmd, int index) request.type = htonl(type | nbd_cmd_flags); if (type != NBD_CMD_FLUSH) { request.from = cpu_to_be64((u64)blk_rq_pos(req) << 9); - request.len = htonl(size); + request.len = htonl(blk_rq_bytes(req)); } handle = nbd_cmd_handle(cmd); request.cookie = cpu_to_be64(handle); |