diff options
| author |  Tomas Winkler <tomas.winkler@intel.com>
| 2018-10-19 21:23:07 +0300 |
|---|---|---|
| committer |  Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
| 2018-11-13 13:46:31 +0200 |
| commit | 95adc6b410b7aa895dcf5ed9cb7dc4a20a3d5c5a (patch) | |
| tree | 0062d5eafaa2653c41a74382f6f77cb8f4f54334 /drivers/char/tpm/tpm-sysfs.c | |
| parent | tpm1: reimplement tpm1_continue_selftest() using tpm_buf (diff) | |
| download | linux-95adc6b410b7aa895dcf5ed9cb7dc4a20a3d5c5a.tar.gz linux-95adc6b410b7aa895dcf5ed9cb7dc4a20a3d5c5a.tar.bz2 linux-95adc6b410b7aa895dcf5ed9cb7dc4a20a3d5c5a.zip | |
tpm: use u32 instead of int for PCR index
The TPM specs defines PCR index as a positive number, and there is
no reason to use a signed number. It is also a possible security
issue as currently no functions check for a negative index,
which may become a large number when converted to u32.
Adjust the API to use u32 instead of int in all PCR related
functions.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Diffstat (limited to 'drivers/char/tpm/tpm-sysfs.c')
| -rw-r--r-- | drivers/char/tpm/tpm-sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c index 96fc7433c57d..b88e08ec2c59 100644 --- a/drivers/char/tpm/tpm-sysfs.c +++ b/drivers/char/tpm/tpm-sysfs.c @@ -102,7 +102,7 @@ static ssize_t pcrs_show(struct device *dev, struct device_attribute *attr, cap_t cap; u8 digest[TPM_DIGEST_SIZE]; ssize_t rc; - int i, j, num_pcrs; + u32 i, j, num_pcrs; char *str = buf; struct tpm_chip *chip = to_tpm_chip(dev); |