diff options
| author |  Giovanni Cabiddu <giovanni.cabiddu@intel.com>
| 2023-09-14 10:55:47 +0100 |
|---|---|---|
| committer |  Herbert Xu <herbert@gondor.apana.org.au>
| 2023-09-20 13:15:30 +0800 |
| commit | 9c20cb8b1847dedddec3d5163079290542bf00bf (patch) | |
| tree | 540d05c41d75f08a1399655a867bc5527d3760a4 /drivers/crypto | |
| parent | crypto: qat - do not shadow error code (diff) | |
| download | linux-9c20cb8b1847dedddec3d5163079290542bf00bf.tar.gz linux-9c20cb8b1847dedddec3d5163079290542bf00bf.tar.bz2 linux-9c20cb8b1847dedddec3d5163079290542bf00bf.zip | |
crypto: qat - ignore subsequent state up commands
If the device is already in the up state, a subsequent write of `up` to
the sysfs attribute /sys/bus/pci/devices/<BDF>/qat/state brings the
device down.
Fix this behaviour by ignoring subsequent `up` commands if the device is
already in the up state.
Fixes: 1bdc85550a2b ("crypto: qat - fix concurrency issue when device state changes")
Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Adam Guerin <adam.guerin@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/intel/qat/qat_common/adf_sysfs.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/crypto/intel/qat/qat_common/adf_sysfs.c b/drivers/crypto/intel/qat/qat_common/adf_sysfs.c index 5e14c374ebd3..8672cfa2800f 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_sysfs.c +++ b/drivers/crypto/intel/qat/qat_common/adf_sysfs.c @@ -68,7 +68,9 @@ static ssize_t state_store(struct device *dev, struct device_attribute *attr, dev_info(dev, "Starting device qat_dev%d\n", accel_id); ret = adf_dev_up(accel_dev, true); - if (ret < 0) { + if (ret == -EALREADY) { + break; + } else if (ret) { dev_err(dev, "Failed to start device qat_dev%d\n", accel_id); adf_dev_down(accel_dev, true); |