diff options
| author |  Dave Jiang <dave.jiang@intel.com>
| 2024-04-03 08:47:12 -0700 |
|---|---|---|
| committer | Dave Jiang <dave.jiang@intel.com>
| 2024-04-05 08:15:50 -0700 |
| commit | 648dae58a830ecceea3b1bebf68432435980f137 (patch) | |
| tree | d83117e7f5c6caafc90895795f1276031cad95ce /drivers/cxl | |
| parent | cxl/core: Fix initialization of mbox_cmd.size_out in get event (diff) | |
| download | linux-648dae58a830ecceea3b1bebf68432435980f137.tar.gz linux-648dae58a830ecceea3b1bebf68432435980f137.tar.bz2 linux-648dae58a830ecceea3b1bebf68432435980f137.zip | |
cxl: Remove checking of iter in cxl_endpoint_get_perf_coordinates()
The while() loop in cxl_endpoint_get_perf_coordinates() checks to see if
'iter' is valid as part of the condition breaking out of the loop.
is_cxl_root() will stop the loop before the next iteration could go NULL.
Remove the iter check.
The presence of the iter or removing the iter does not impact the behavior
of the code. This is a code clean up and not a bug fix.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Link: https://lore.kernel.org/r/20240403154844.3403859-2-dave.jiang@intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Diffstat (limited to 'drivers/cxl')
| -rw-r--r-- | drivers/cxl/core/port.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c index 2b0cab556072..6cbde50a742b 100644 --- a/drivers/cxl/core/port.c +++ b/drivers/cxl/core/port.c @@ -2197,7 +2197,7 @@ int cxl_endpoint_get_perf_coordinates(struct cxl_port *port, * port each iteration. If the parent is cxl root then there is * nothing to gather. */ - while (iter && !is_cxl_root(to_cxl_port(iter->dev.parent))) { + while (!is_cxl_root(to_cxl_port(iter->dev.parent))) { cxl_coordinates_combine(&c, &c, &dport->sw_coord); c.write_latency += dport->link_latency; c.read_latency += dport->link_latency; |