diff options
| author |  Christian Marangi <ansuelsmth@gmail.com>
| 2022-06-20 00:03:51 +0200 |
|---|---|---|
| committer |  Chanwoo Choi <cw00.choi@samsung.com>
| 2022-06-30 05:11:17 +0900 |
| commit | b5d281f6c16dd432b618bdfd36ddba1a58d5b603 (patch) | |
| tree | 0c284f1e8dee4aedc13b1e9d39d569d745f2ac60 /drivers/devfreq/governor_passive.c | |
| parent | PM / devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events (diff) | |
| download | linux-b5d281f6c16dd432b618bdfd36ddba1a58d5b603.tar.gz linux-b5d281f6c16dd432b618bdfd36ddba1a58d5b603.tar.bz2 linux-b5d281f6c16dd432b618bdfd36ddba1a58d5b603.zip | |
PM / devfreq: Rework freq_table to be local to devfreq struct
On a devfreq PROBE_DEFER, the freq_table in the driver profile struct,
is never reset and may be leaved in an undefined state.
This comes from the fact that we store the freq_table in the driver
profile struct that is commonly defined as static and not reset on
PROBE_DEFER.
We currently skip the reinit of the freq_table if we found
it's already defined since a driver may declare his own freq_table.
This logic is flawed in the case devfreq core generate a freq_table, set
it in the profile struct and then PROBE_DEFER, freeing the freq_table.
In this case devfreq will found a NOT NULL freq_table that has been
freed, skip the freq_table generation and probe the driver based on the
wrong table.
To fix this and correctly handle PROBE_DEFER, use a local freq_table and
max_state in the devfreq struct and never modify the freq_table present
in the profile struct if it does provide it.
Fixes: 0ec09ac2cebe ("PM / devfreq: Set the freq_table of devfreq device")
Cc: stable@vger.kernel.org
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/devfreq/governor_passive.c')
| -rw-r--r-- | drivers/devfreq/governor_passive.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c index 69e06725d92b..406ef79c0c46 100644 --- a/drivers/devfreq/governor_passive.c +++ b/drivers/devfreq/governor_passive.c @@ -144,18 +144,18 @@ static int get_target_freq_with_devfreq(struct devfreq *devfreq, goto out; /* Use interpolation if required opps is not available */ - for (i = 0; i < parent_devfreq->profile->max_state; i++) - if (parent_devfreq->profile->freq_table[i] == *freq) + for (i = 0; i < parent_devfreq->max_state; i++) + if (parent_devfreq->freq_table[i] == *freq) break; - if (i == parent_devfreq->profile->max_state) + if (i == parent_devfreq->max_state) return -EINVAL; - if (i < devfreq->profile->max_state) { - child_freq = devfreq->profile->freq_table[i]; + if (i < devfreq->max_state) { + child_freq = devfreq->freq_table[i]; } else { - count = devfreq->profile->max_state; - child_freq = devfreq->profile->freq_table[count - 1]; + count = devfreq->max_state; + child_freq = devfreq->freq_table[count - 1]; } out: |