diff options
| author |  Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
| 2022-04-04 16:55:57 +0100 |
|---|---|---|
| committer |  Vinod Koul <vkoul@kernel.org>
| 2022-04-11 16:26:53 +0530 |
| commit | 80380f89d0f56e0efa43e24c11f989e89b4af952 (patch) | |
| tree | 9b5e2b2a575d97389454e4e79ff4cf886d460385 /drivers/dma/mediatek | |
| parent | dmaengine: mediatek: mtk-hsdma: Use platform_get_irq() to get the interrupt (diff) | |
| download | linux-80380f89d0f56e0efa43e24c11f989e89b4af952.tar.gz linux-80380f89d0f56e0efa43e24c11f989e89b4af952.tar.bz2 linux-80380f89d0f56e0efa43e24c11f989e89b4af952.zip | |
dmaengine: mediatek-cqdma: Use platform_get_irq() to get the interrupt
platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.
In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20220404155557.27316-4-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/mediatek')
| -rw-r--r-- | drivers/dma/mediatek/mtk-cqdma.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c index 41ef9f15d3d5..f8847c48ba03 100644 --- a/drivers/dma/mediatek/mtk-cqdma.c +++ b/drivers/dma/mediatek/mtk-cqdma.c @@ -751,7 +751,6 @@ static int mtk_cqdma_probe(struct platform_device *pdev) struct mtk_cqdma_device *cqdma; struct mtk_cqdma_vchan *vc; struct dma_device *dd; - struct resource *res; int err; u32 i; @@ -824,13 +823,10 @@ static int mtk_cqdma_probe(struct platform_device *pdev) return PTR_ERR(cqdma->pc[i]->base); /* allocate IRQ resource */ - res = platform_get_resource(pdev, IORESOURCE_IRQ, i); - if (!res) { - dev_err(&pdev->dev, "No irq resource for %s\n", - dev_name(&pdev->dev)); - return -EINVAL; - } - cqdma->pc[i]->irq = res->start; + err = platform_get_irq(pdev, i); + if (err < 0) + return err; + cqdma->pc[i]->irq = err; err = devm_request_irq(&pdev->dev, cqdma->pc[i]->irq, mtk_cqdma_irq, 0, dev_name(&pdev->dev), |