diff options
author | 2024-02-16 14:06:36 -0800 | |
---|---|---|
committer | 2024-03-04 10:23:19 -0800 | |
commit | 363f689600dd010703ce6391bcfc729a97d21840 (patch) | |
tree | f95fef9d84b47c77d81e6be409bc6de4f832f42c /drivers/edac | |
parent | ice: pass VSI pointer into ice_vc_isvalid_q_id (diff) | |
download | linux-363f689600dd010703ce6391bcfc729a97d21840.tar.gz linux-363f689600dd010703ce6391bcfc729a97d21840.tar.bz2 linux-363f689600dd010703ce6391bcfc729a97d21840.zip |
ice: remove unnecessary duplicate checks for VF VSI ID
The ice_vc_fdir_param_check() function validates that the VSI ID of the
virtchnl flow director command matches the VSI number of the VF. This is
already checked by the call to ice_vc_isvalid_vsi_id() immediately
following this.
This check is unnecessary since ice_vc_isvalid_vsi_id() already confirms
this by checking that the VSI ID can locate the VSI associated with the VF
structure.
Furthermore, a following change is going to refactor the ice driver to
report VSI IDs using a relative index for each VF instead of reporting the
PF VSI number. This additional check would break that logic since it
enforces that the VSI ID matches the VSI number.
Since this check duplicates the logic in ice_vc_isvalid_vsi_id() and gets
in the way of refactoring that logic, remove it.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'drivers/edac')
0 files changed, 0 insertions, 0 deletions