diff options
| author |  Sudeep Holla <sudeep.holla@arm.com>
| 2023-10-31 14:13:35 +0000 |
|---|---|---|
| committer | Sudeep Holla <sudeep.holla@arm.com>
| 2023-11-13 11:51:26 +0000 |
| commit | 05857a1eb723190923b091a857184ced17a83770 (patch) | |
| tree | 9a7163a996697fafac600004d7fd46dcf20b9a65 /drivers/firmware | |
| parent | firmware: arm_ffa: Fix FFA notifications cleanup path (diff) | |
| download | linux-05857a1eb723190923b091a857184ced17a83770.tar.gz linux-05857a1eb723190923b091a857184ced17a83770.tar.bz2 linux-05857a1eb723190923b091a857184ced17a83770.zip | |
firmware: arm_ffa: Fix the size of the allocation in ffa_partitions_cleanup()
Arry of pointer to struct ffa_dev_part_info needs to be allocated to
fetch the pointers stored in XArray. However, currently we allocate the
entire structure instead of just pointers.
Fix the allocation size. This will also eliminate the below Smatch
istatic checker warning:
| drivers/firmware/arm_ffa/driver.c:1251 ffa_partitions_cleanup()
| warn: double check that we're allocating correct size: 8 vs 88
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/0e8ddbca-d9da-4a3b-aae3-328993b62ba2@moroto.mountain
Link: https://lore.kernel.org/r/20231031141335.3077026-1-sudeep.holla@arm.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/arm_ffa/driver.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 49ebdc2775dd..034bce8a2ca1 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -1248,7 +1248,7 @@ static void ffa_partitions_cleanup(void) if (!count) return; - info = kcalloc(count, sizeof(**info), GFP_KERNEL); + info = kcalloc(count, sizeof(*info), GFP_KERNEL); if (!info) return; |