diff options
| author |  Kent Gibson <warthog618@gmail.com>
| 2023-06-06 20:00:34 +0800 |
|---|---|---|
| committer |  Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
| 2023-06-06 17:02:34 +0200 |
| commit | 95ae9979bfe3174c2ee8d64409c44532f2881907 (patch) | |
| tree | ea385fe41449603594bd8aadd1c83464aaebbccc /drivers/gpio | |
| parent | Linux 6.4-rc5 (diff) | |
| download | linux-95ae9979bfe3174c2ee8d64409c44532f2881907.tar.gz linux-95ae9979bfe3174c2ee8d64409c44532f2881907.tar.bz2 linux-95ae9979bfe3174c2ee8d64409c44532f2881907.zip | |
gpio: sim: fix memory corruption when adding named lines and unnamed hogs
When constructing the sim, gpio-sim constructs an array of named lines,
sized based on the largest offset of any named line, and then initializes
that array with the names of all lines, including unnamed hogs with higher
offsets. In doing so it writes NULLs beyond the extent of the array.
Add a check that only named lines are used to initialize the array.
Fixes: cb8c474e79be ("gpio: sim: new testing module")
Signed-off-by: Kent Gibson<warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-sim.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index a1c8702f362c..fab67a5785d7 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -721,8 +721,10 @@ static char **gpio_sim_make_line_names(struct gpio_sim_bank *bank, if (!line_names) return ERR_PTR(-ENOMEM); - list_for_each_entry(line, &bank->line_list, siblings) - line_names[line->offset] = line->name; + list_for_each_entry(line, &bank->line_list, siblings) { + if (line->name && (line->offset <= max_offset)) + line_names[line->offset] = line->name; + } return line_names; } |