diff options
| author |  Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
| 2023-07-13 18:43:49 +0530 |
|---|---|---|
| committer |  Alex Deucher <alexander.deucher@amd.com>
| 2023-07-18 11:09:30 -0400 |
| commit | a62e702ee1a1ae08693aeaa4ae1fc1448cbd5a19 (patch) | |
| tree | 7a3618e38a9a3b520f77f4e94ccfc2a0177446ee /drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | |
| parent | drm/amd/display: Eliminate warnings in amdgpu_dm_helpers.c (diff) | |
| download | linux-a62e702ee1a1ae08693aeaa4ae1fc1448cbd5a19.tar.gz linux-a62e702ee1a1ae08693aeaa4ae1fc1448cbd5a19.tar.bz2 linux-a62e702ee1a1ae08693aeaa4ae1fc1448cbd5a19.zip | |
drm/amdgpu: Avoid possiblity of kernel crash in 'gmc_v8_0, gmc_v7_0_init_microcode()'
If the function 'gmc_v8_0_ or gmc_v7_0_init_microcode()' fails, the
driver will just fail to load, hence return -EINVAL rather having BUG(),
fixes WARNING: Do not crash the kernel unless it is absolutely
unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead
of BUG() or variants
Fixes: 2f77b5931f68 ("drm/amdgpu: Fix error & warnings in gmc_v8_0.c")
Fixes: 0cfc1d683046 ("drm/amdgpu: Fix errors & warnings in gmc_ v6_0, v7_0.c")
Suggested-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c')
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c index 0629b6808cb1..6a6929ac2748 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c @@ -150,7 +150,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev) case CHIP_MULLINS: return 0; default: - BUG(); + return -EINVAL; } snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); |