diff options
| author |  Jiasheng Jiang <jiasheng@iscas.ac.cn>
| 2022-06-02 18:34:01 +0800 |
|---|---|---|
| committer |  Sam Ravnborg <sam@ravnborg.org>
| 2022-06-24 22:32:02 +0200 |
| commit | 831463667b5f4f1e5bce9c3b94e9e794d2bc8923 (patch) | |
| tree | 5a218b75bf2ab3a0338ac053db0f3817b940b7ed /drivers/gpu/drm/bridge/adv7511 | |
| parent | drm/bridge: parade-ps8622: Use backlight helper (diff) | |
| download | linux-831463667b5f4f1e5bce9c3b94e9e794d2bc8923.tar.gz linux-831463667b5f4f1e5bce9c3b94e9e794d2bc8923.tar.bz2 linux-831463667b5f4f1e5bce9c3b94e9e794d2bc8923.zip | |
drm: bridge: adv7511: Add check for mipi_dsi_driver_register
As mipi_dsi_driver_register could return error if fails,
it should be better to check the return value and return error
if fails.
Moreover, if i2c_add_driver fails, mipi_dsi_driver_register
should be reverted.
Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220602103401.2980938-1-jiasheng@iscas.ac.cn
Diffstat (limited to 'drivers/gpu/drm/bridge/adv7511')
| -rw-r--r-- | drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 074c2e650cae..38bf28720f3a 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1393,10 +1393,21 @@ static struct i2c_driver adv7511_driver = { static int __init adv7511_init(void) { - if (IS_ENABLED(CONFIG_DRM_MIPI_DSI)) - mipi_dsi_driver_register(&adv7533_dsi_driver); + int ret; + + if (IS_ENABLED(CONFIG_DRM_MIPI_DSI)) { + ret = mipi_dsi_driver_register(&adv7533_dsi_driver); + if (ret) + return ret; + } - return i2c_add_driver(&adv7511_driver); + ret = i2c_add_driver(&adv7511_driver); + if (ret) { + if (IS_ENABLED(CONFIG_DRM_MIPI_DSI)) + mipi_dsi_driver_unregister(&adv7533_dsi_driver); + } + + return ret; } module_init(adv7511_init); |