aboutsummaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/i915/intel_hdmi.c
diff options
context:
space:
mode:
authorGravatar Daniel Vetter <daniel.vetter@ffwll.ch> 2014-04-24 23:54:46 +0200
committerGravatar Daniel Vetter <daniel.vetter@ffwll.ch> 2014-05-16 11:57:33 +0200
commitabac6a009c34cb4d191360dd17c5c4a804ab392a (patch)
tree6fdbd745949db24b436fabd44b4258d317f6b7ae /drivers/gpu/drm/i915/intel_hdmi.c
parentdrm/i915: Enable rc6 with bdw (diff)
downloadlinux-abac6a009c34cb4d191360dd17c5c4a804ab392a.tar.gz
linux-abac6a009c34cb4d191360dd17c5c4a804ab392a.tar.bz2
linux-abac6a009c34cb4d191360dd17c5c4a804ab392a.zip
drm/i915/hdmi: Enable hdmi mode on g4x, too
For compliance we really should be sending NULL infoframes always when we detect a hdmi capable monitor. Also remove the now redudant setting for the has_audio case and enforce that audio is only possible with a hdmi sink. Reviewed-by: Naresh Kumar Kachhi <naresh.kumar.kachhi@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_hdmi.c')
-rw-r--r--drivers/gpu/drm/i915/intel_hdmi.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index e422cfaebb03..7a603eb5b56f 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -650,15 +650,14 @@ static void intel_hdmi_mode_set(struct intel_encoder *encoder)
else
hdmi_val |= SDVO_COLOR_FORMAT_8bpc;
- if (intel_hdmi->has_hdmi_sink &&
- (HAS_PCH_CPT(dev) || IS_VALLEYVIEW(dev)))
+ if (intel_hdmi->has_hdmi_sink)
hdmi_val |= HDMI_MODE_SELECT_HDMI;
if (intel_hdmi->has_audio) {
+ WARN_ON(!intel_hdmi->has_hdmi_sink);
DRM_DEBUG_DRIVER("Enabling HDMI audio on pipe %c\n",
pipe_name(crtc->pipe));
hdmi_val |= SDVO_AUDIO_ENABLE;
- hdmi_val |= HDMI_MODE_SELECT_HDMI;
intel_write_eld(&encoder->base, adjusted_mode);
}