diff options
| author |  Uwe Kleine-König <uwe@kleine-koenig.org>
| 2021-02-06 16:13:48 +0100 |
|---|---|---|
| committer |  Jiri Kosina <jkosina@suse.cz>
| 2021-03-08 17:16:03 +0100 |
| commit | e71da1fd0e84bc5c87a78b405e40713840eecc80 (patch) | |
| tree | a2fe6e0fde7924f1f3b8e365870b893a94728b9e /drivers/hid/intel-ish-hid/ishtp-fw-loader.c | |
| parent | HID: intel-ish-hid: Simplify logic in ishtp_cl_device_remove() (diff) | |
| download | linux-e71da1fd0e84bc5c87a78b405e40713840eecc80.tar.gz linux-e71da1fd0e84bc5c87a78b405e40713840eecc80.tar.bz2 linux-e71da1fd0e84bc5c87a78b405e40713840eecc80.zip | |
HID: intel-ish-hid: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove()
because there is only little that can be done. To simplify the quest to
make this function return void, let struct ishtp_cl_driver::remove() return
void, too. All users already unconditionally return 0, this commit makes
it obvious that returning an error value is a bad idea.
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/intel-ish-hid/ishtp-fw-loader.c')
| -rw-r--r-- | drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c index 6cf59fd26ad7..edb0bd084c27 100644 --- a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c +++ b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c @@ -1015,7 +1015,7 @@ static int loader_ishtp_cl_probe(struct ishtp_cl_device *cl_device) * * Return: 0 */ -static int loader_ishtp_cl_remove(struct ishtp_cl_device *cl_device) +static void loader_ishtp_cl_remove(struct ishtp_cl_device *cl_device) { struct ishtp_cl_data *client_data; struct ishtp_cl *loader_ishtp_cl = ishtp_get_drvdata(cl_device); @@ -1032,8 +1032,6 @@ static int loader_ishtp_cl_remove(struct ishtp_cl_device *cl_device) cancel_work_sync(&client_data->work_ishtp_reset); loader_deinit(loader_ishtp_cl); ishtp_put_device(cl_device); - - return 0; } /** |