diff options
author | 2016-02-26 15:13:19 -0800 | |
---|---|---|
committer | 2016-03-01 16:57:20 -0800 | |
commit | b9830d120cbe155863399f25eaef6aa8353e767f (patch) | |
tree | 7aeea7c18f0ba6ac4c3b73658fc1c27db718fd17 /drivers/hv/hv_snapshot.c | |
parent | Drivers: hv: vmbus: avoid unneeded compiler optimizations in vmbus_wait_for_u... (diff) | |
download | linux-b9830d120cbe155863399f25eaef6aa8353e767f.tar.gz linux-b9830d120cbe155863399f25eaef6aa8353e767f.tar.bz2 linux-b9830d120cbe155863399f25eaef6aa8353e767f.zip |
Drivers: hv: util: Pass the channel information during the init call
Pass the channel information to the util drivers that need to defer
reading the channel while they are processing a request. This would address
the following issue reported by Vitaly:
Commit 3cace4a61610 ("Drivers: hv: utils: run polling callback always in
interrupt context") removed direct *_transaction.state = HVUTIL_READY
assignments from *_handle_handshake() functions introducing the following
race: if a userspace daemon connects before we get first non-negotiation
request from the server hv_poll_channel() won't set transaction state to
HVUTIL_READY as (!channel) condition will fail, we set it to non-NULL on
the first real request from the server.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hv/hv_snapshot.c')
-rw-r--r-- | drivers/hv/hv_snapshot.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c index 67def4a831c8..3fba14e88f03 100644 --- a/drivers/hv/hv_snapshot.c +++ b/drivers/hv/hv_snapshot.c @@ -263,7 +263,6 @@ void hv_vss_onchannelcallback(void *context) */ vss_transaction.recv_len = recvlen; - vss_transaction.recv_channel = channel; vss_transaction.recv_req_id = requestid; vss_transaction.msg = (struct hv_vss_msg *)vss_msg; @@ -337,6 +336,7 @@ hv_vss_init(struct hv_util_service *srv) return -ENOTSUPP; } recv_buffer = srv->recv_buffer; + vss_transaction.recv_channel = srv->channel; /* * When this driver loads, the user level daemon that |