diff options
| author |  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
| 2020-05-19 15:50:40 +0300 |
|---|---|---|
| committer |  Wolfram Sang <wsa@kernel.org>
| 2020-05-22 16:50:30 +0200 |
| commit | 462cfcb4aa1c92239cb16177fd3ceb65326955ff (patch) | |
| tree | 9b9a9a95d618b28a9ba5d034c3b30caa31873771 /drivers/i2c/busses | |
| parent | i2c: designware: Move i2c_dw_validate_speed() helper to a common code (diff) | |
| download | linux-462cfcb4aa1c92239cb16177fd3ceb65326955ff.tar.gz linux-462cfcb4aa1c92239cb16177fd3ceb65326955ff.tar.bz2 linux-462cfcb4aa1c92239cb16177fd3ceb65326955ff.zip | |
i2c: designware: Drop unneeded condition in i2c_dw_validate_speed()
We may bailout directly from the loop instead of breaking it and
testing a loop counter. This also gives advantages such as decreased
indentation level along with dropped unneeded condition.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c/busses')
| -rw-r--r-- | drivers/i2c/busses/i2c-designware-common.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index 9f06567be54a..2fd5372b1237 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -127,16 +127,14 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev) */ for (i = 0; i < ARRAY_SIZE(i2c_dw_supported_speeds); i++) { if (t->bus_freq_hz == i2c_dw_supported_speeds[i]) - break; - } - if (i == ARRAY_SIZE(i2c_dw_supported_speeds)) { - dev_err(dev->dev, - "%d Hz is unsupported, only 100kHz, 400kHz, 1MHz and 3.4MHz are supported\n", - t->bus_freq_hz); - return -EINVAL; + return 0; } - return 0; + dev_err(dev->dev, + "%d Hz is unsupported, only 100kHz, 400kHz, 1MHz and 3.4MHz are supported\n", + t->bus_freq_hz); + + return -EINVAL; } EXPORT_SYMBOL_GPL(i2c_dw_validate_speed); |