diff options
| author |  Lars-Peter Clausen <lars@metafoo.de>
| 2023-04-13 19:10:21 -0700 |
|---|---|---|
| committer |  Wolfram Sang <wsa@kernel.org>
| 2023-04-18 18:43:45 +0200 |
| commit | ae1664f04f504a998737f5bb563f16b44357bcca (patch) | |
| tree | 43337569106643a99ce2d6f01864fe2ef35956bc /drivers/i2c | |
| parent | Linux 6.3-rc7 (diff) | |
| download | linux-ae1664f04f504a998737f5bb563f16b44357bcca.tar.gz linux-ae1664f04f504a998737f5bb563f16b44357bcca.tar.bz2 linux-ae1664f04f504a998737f5bb563f16b44357bcca.zip | |
i2c: cadence: cdns_i2c_master_xfer(): Fix runtime PM leak on error path
The cdns_i2c_master_xfer() function gets a runtime PM reference when the
function is entered. This reference is released when the function is
exited. There is currently one error path where the function exits
directly, which leads to a leak of the runtime PM reference.
Make sure that this error path also releases the runtime PM reference.
Fixes: 1a351b10b967 ("i2c: cadence: Added slave support")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-cadence.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c index b5d22e7282c2..982c207d473b 100644 --- a/drivers/i2c/busses/i2c-cadence.c +++ b/drivers/i2c/busses/i2c-cadence.c @@ -827,8 +827,10 @@ static int cdns_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, #if IS_ENABLED(CONFIG_I2C_SLAVE) /* Check i2c operating mode and switch if possible */ if (id->dev_mode == CDNS_I2C_MODE_SLAVE) { - if (id->slave_state != CDNS_I2C_SLAVE_STATE_IDLE) - return -EAGAIN; + if (id->slave_state != CDNS_I2C_SLAVE_STATE_IDLE) { + ret = -EAGAIN; + goto out; + } /* Set mode to master */ cdns_i2c_set_mode(CDNS_I2C_MODE_MASTER, id); |