aboutsummaryrefslogtreecommitdiff
path: root/drivers/iio
diff options
context:
space:
mode:
authorGravatar Nuno Sa <nuno.sa@analog.com> 2024-04-19 17:36:45 +0200
committerGravatar Jonathan Cameron <Jonathan.Cameron@huawei.com> 2024-04-20 16:01:04 +0100
commitcf1c833f89e7c8635a28c3db15c68ead150ea712 (patch)
tree220db99bbb494d45f07ee9ffc853e4d60e3feb5a /drivers/iio
parentiio: dac: support the ad9739a RF DAC (diff)
downloadlinux-cf1c833f89e7c8635a28c3db15c68ead150ea712.tar.gz
linux-cf1c833f89e7c8635a28c3db15c68ead150ea712.tar.bz2
linux-cf1c833f89e7c8635a28c3db15c68ead150ea712.zip
iio: adc: adi-axi-adc: only error out in major version mismatch
The IP core only has breaking changes when there major version changes. Hence, only match the major number. This is also in line with the other core ADI has upstream. The current check for erroring out 'expected_version > current_version"' is then wrong as we could just increase the core major with breaking changes and that would go unnoticed. Fixes: ef04070692a2 ("iio: adc: adi-axi-adc: add support for AXI ADC IP core") Signed-off-by: Nuno Sa <nuno.sa@analog.com> Link: https://lore.kernel.org/r/20240419-ad9467-new-features-v1-2-3e7628ff6d5e@analog.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio')
-rw-r--r--drivers/iio/adc/adi-axi-adc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c
index 184b36dca6d0..9444b0c5a93c 100644
--- a/drivers/iio/adc/adi-axi-adc.c
+++ b/drivers/iio/adc/adi-axi-adc.c
@@ -193,9 +193,9 @@ static int adi_axi_adc_probe(struct platform_device *pdev)
if (ret)
return ret;
- if (*expected_ver > ver) {
+ if (ADI_AXI_PCORE_VER_MAJOR(ver) != ADI_AXI_PCORE_VER_MAJOR(*expected_ver)) {
dev_err(&pdev->dev,
- "IP core version is too old. Expected %d.%.2d.%c, Reported %d.%.2d.%c\n",
+ "Major version mismatch. Expected %d.%.2d.%c, Reported %d.%.2d.%c\n",
ADI_AXI_PCORE_VER_MAJOR(*expected_ver),
ADI_AXI_PCORE_VER_MINOR(*expected_ver),
ADI_AXI_PCORE_VER_PATCH(*expected_ver),