diff options
| author |  Hans de Goede <hdegoede@redhat.com>
| 2023-03-17 03:48:07 -0700 |
|---|---|---|
| committer |  Dmitry Torokhov <dmitry.torokhov@gmail.com>
| 2023-03-17 03:55:15 -0700 |
| commit | 10b0a455f4378330de41e280ce7839997d24297d (patch) | |
| tree | ab3f34058dfc26fe13bbbccd345fcd30895ac771 /drivers/input | |
| parent | Input: hideep - clean up some inconsistent indenting (diff) | |
| download | linux-10b0a455f4378330de41e280ce7839997d24297d.tar.gz linux-10b0a455f4378330de41e280ce7839997d24297d.tar.bz2 linux-10b0a455f4378330de41e280ce7839997d24297d.zip | |
Input: hideep - silence error in SW_RESET()
On some models the first HIDEEP_SYSCON_WDT_CON write alone is enough to
cause the controller to reset, causing the second write to fail:
i2c-hideep_ts: write to register 0x52000014 (0x000001) failed: -121
Switch this write to a raw hideep_pgm_w_mem() to avoid an error getting
logged in this case.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20230311114726.182789-2-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
| -rw-r--r-- | drivers/input/touchscreen/hideep.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/input/touchscreen/hideep.c b/drivers/input/touchscreen/hideep.c index 05998e83c36a..b47feb63cfb8 100644 --- a/drivers/input/touchscreen/hideep.c +++ b/drivers/input/touchscreen/hideep.c @@ -271,9 +271,14 @@ static int hideep_pgm_w_reg(struct hideep_ts *ts, u32 addr, u32 val) #define SW_RESET_IN_PGM(clk) \ { \ + __be32 data = cpu_to_be32(0x01); \ hideep_pgm_w_reg(ts, HIDEEP_SYSCON_WDT_CNT, (clk)); \ hideep_pgm_w_reg(ts, HIDEEP_SYSCON_WDT_CON, 0x03); \ - hideep_pgm_w_reg(ts, HIDEEP_SYSCON_WDT_CON, 0x01); \ + /* \ + * The first write may already cause a reset, use a raw \ + * write for the second write to avoid error logging. \ + */ \ + hideep_pgm_w_mem(ts, HIDEEP_SYSCON_WDT_CON, &data, 1); \ } #define SET_FLASH_PIO(ce) \ |