diff options
| author |  Ashish Mhetre <amhetre@nvidia.com>
| 2023-12-05 12:26:56 +0530 |
|---|---|---|
| committer |  Joerg Roedel <jroedel@suse.de>
| 2023-12-19 14:35:54 +0100 |
| commit | bb57f6705960bebeb832142ce9abf43220c3eab1 (patch) | |
| tree | c5b079ec1144b7a0d3817b853e5fea15f65b2127 /drivers/iommu/of_iommu.c | |
| parent | iommu/sva: Fix memory leak in iommu_sva_bind_device() (diff) | |
| download | linux-bb57f6705960bebeb832142ce9abf43220c3eab1.tar.gz linux-bb57f6705960bebeb832142ce9abf43220c3eab1.tar.bz2 linux-bb57f6705960bebeb832142ce9abf43220c3eab1.zip | |
iommu: Don't reserve 0-length IOVA region
When the bootloader/firmware doesn't setup the framebuffers, their
address and size are 0 in "iommu-addresses" property. If IOVA region is
reserved with 0 length, then it ends up corrupting the IOVA rbtree with
an entry which has pfn_hi < pfn_lo.
If we intend to use display driver in kernel without framebuffer then
it's causing the display IOMMU mappings to fail as entire valid IOVA
space is reserved when address and length are passed as 0.
An ideal solution would be firmware removing the "iommu-addresses"
property and corresponding "memory-region" if display is not present.
But the kernel should be able to handle this by checking for size of
IOVA region and skipping the IOVA reservation if size is 0. Also, add
a warning if firmware is requesting 0-length IOVA region reservation.
Fixes: a5bf3cfce8cb ("iommu: Implement of_iommu_get_resv_regions()")
Signed-off-by: Ashish Mhetre <amhetre@nvidia.com>
Acked-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/20231205065656.9544-1-amhetre@nvidia.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/of_iommu.c')
| -rw-r--r-- | drivers/iommu/of_iommu.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 164317bfb8a8..691335a903a8 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -252,6 +252,10 @@ void of_iommu_get_resv_regions(struct device *dev, struct list_head *list) prot |= IOMMU_CACHE; maps = of_translate_dma_region(np, maps, &iova, &length); + if (length == 0) { + dev_warn(dev, "Cannot reserve IOVA region of 0 size\n"); + continue; + } type = iommu_resv_region_get_type(dev, &phys, iova, length); region = iommu_alloc_resv_region(iova, length, prot, type, |