aboutsummaryrefslogtreecommitdiff
path: root/drivers/irqchip
diff options
context:
space:
mode:
authorGravatar Miaoqian Lin <linmq006@gmail.com> 2022-06-01 12:09:26 +0400
committerGravatar Marc Zyngier <maz@kernel.org> 2022-06-09 17:36:57 +0100
commitb1ac803f47cb1615468f35cf1ccb553c52087301 (patch)
treee1e382411d7373145716c92c9ac37c440536b64f /drivers/irqchip
parentirqchip/gic/realview: Fix refcount leak in realview_gic_of_init (diff)
downloadlinux-b1ac803f47cb1615468f35cf1ccb553c52087301.tar.gz
linux-b1ac803f47cb1615468f35cf1ccb553c52087301.tar.bz2
linux-b1ac803f47cb1615468f35cf1ccb553c52087301.zip
irqchip/apple-aic: Fix refcount leak in build_fiq_affinity
of_find_node_by_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5e8801202b3 ("irqchip/apple-aic: Parse FIQ affinities from device-tree") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220601080930.31005-3-linmq006@gmail.com
Diffstat (limited to 'drivers/irqchip')
-rw-r--r--drivers/irqchip/irq-apple-aic.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 12dd48727a15..478d0af16d9f 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -1035,6 +1035,7 @@ static void build_fiq_affinity(struct aic_irq_chip *ic, struct device_node *aff)
continue;
cpu = of_cpu_node_to_id(cpu_node);
+ of_node_put(cpu_node);
if (WARN_ON(cpu < 0))
continue;