diff options
| author |  Junhao He <hejunhao3@huawei.com>
| 2023-10-24 19:36:30 +0800 |
|---|---|---|
| committer |  Will Deacon <will@kernel.org>
| 2023-10-24 13:30:02 +0100 |
| commit | b805cafc604bfdb671fae7347a57f51154afa735 (patch) | |
| tree | 3fbe50f0164872970248473af0d9ede4d9d56074 /drivers/irqchip | |
| parent | drivers/perf: hisi_pcie: Initialize event->cpu only on success (diff) | |
| download | linux-b805cafc604bfdb671fae7347a57f51154afa735.tar.gz linux-b805cafc604bfdb671fae7347a57f51154afa735.tar.bz2 linux-b805cafc604bfdb671fae7347a57f51154afa735.zip | |
perf: hisi: Fix use-after-free when register pmu fails
When we fail to register the uncore pmu, the pmu context may not been
allocated. The error handing will call cpuhp_state_remove_instance()
to call uncore pmu offline callback, which migrate the pmu context.
Since that's liable to lead to some kind of use-after-free.
Use cpuhp_state_remove_instance_nocalls() instead of
cpuhp_state_remove_instance() so that the notifiers don't execute after
the PMU device has been failed to register.
Fixes: a0ab25cd82ee ("drivers/perf: hisi: Add support for HiSilicon PA PMU driver")
FIxes: 3bf30882c3c7 ("drivers/perf: hisi: Add support for HiSilicon SLLC PMU driver")
Signed-off-by: Junhao He <hejunhao3@huawei.com>
Link: https://lore.kernel.org/r/20231024113630.13472-1-hejunhao3@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'drivers/irqchip')
0 files changed, 0 insertions, 0 deletions