diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2024-01-10 16:42:53 +0100 |
|---|---|---|
| committer |  Michael Ellerman <mpe@ellerman.id.au>
| 2024-02-16 12:35:15 +1100 |
| commit | 7cfe99872c711ffa727db85c608a0897955a2758 (patch) | |
| tree | a0807170b8b48db3c0d93a84f215689b2409371b /drivers/macintosh | |
| parent | macintosh: windfarm_pm81: Convert to platform remove callback returning void (diff) | |
| download | linux-7cfe99872c711ffa727db85c608a0897955a2758.tar.gz linux-7cfe99872c711ffa727db85c608a0897955a2758.tar.bz2 linux-7cfe99872c711ffa727db85c608a0897955a2758.zip | |
macintosh: windfarm_pm91: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/398f9079cacd5b87a930181c250aad2ad4d31424.1704900449.git.u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/macintosh')
| -rw-r--r-- | drivers/macintosh/windfarm_pm91.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm_pm91.c index 120a9cfba0c5..fba02a375435 100644 --- a/drivers/macintosh/windfarm_pm91.c +++ b/drivers/macintosh/windfarm_pm91.c @@ -647,7 +647,7 @@ static int wf_smu_probe(struct platform_device *ddev) return 0; } -static int wf_smu_remove(struct platform_device *ddev) +static void wf_smu_remove(struct platform_device *ddev) { wf_unregister_client(&wf_smu_events); @@ -691,13 +691,11 @@ static int wf_smu_remove(struct platform_device *ddev) kfree(wf_smu_slots_fans); kfree(wf_smu_drive_fans); kfree(wf_smu_cpu_fans); - - return 0; } static struct platform_driver wf_smu_driver = { - .probe = wf_smu_probe, - .remove = wf_smu_remove, + .probe = wf_smu_probe, + .remove_new = wf_smu_remove, .driver = { .name = "windfarm", }, |