diff options
| author |  Stephen Kitt <steve@sk2.org>
| 2022-06-16 19:04:24 +0200 |
|---|---|---|
| committer |  Michael Ellerman <mpe@ellerman.id.au>
| 2022-11-24 23:12:17 +1100 |
| commit | a0542d2c45a64162e63ad2d80684e57de0566271 (patch) | |
| tree | e0346e55df262af56e75541089fa0db3153b2a11 /drivers/macintosh | |
| parent | macintosh/via-pmu: Avoid compiler warnings when CONFIG_PROC_FS is disabled (diff) | |
| download | linux-a0542d2c45a64162e63ad2d80684e57de0566271.tar.gz linux-a0542d2c45a64162e63ad2d80684e57de0566271.tar.bz2 linux-a0542d2c45a64162e63ad2d80684e57de0566271.zip | |
macintosh/via-pmu-backlight: Use backlight helper
backlight_properties.fb_blank is deprecated. The states it represents
are handled by other properties; but instead of accessing those
properties directly, drivers should use the helpers provided by
backlight.h.
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt <steve@sk2.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220616170425.1346081-1-steve@sk2.org
Diffstat (limited to 'drivers/macintosh')
| -rw-r--r-- | drivers/macintosh/via-pmu-backlight.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c index 2194016122d2..c2d87e7fa85b 100644 --- a/drivers/macintosh/via-pmu-backlight.c +++ b/drivers/macintosh/via-pmu-backlight.c @@ -71,12 +71,7 @@ static int pmu_backlight_get_level_brightness(int level) static int __pmu_backlight_update_status(struct backlight_device *bd) { struct adb_request req; - int level = bd->props.brightness; - - - if (bd->props.power != FB_BLANK_UNBLANK || - bd->props.fb_blank != FB_BLANK_UNBLANK) - level = 0; + int level = backlight_get_brightness(bd); if (level > 0) { int pmulevel = pmu_backlight_get_level_brightness(level); |