diff options
author | 2017-07-09 20:57:06 -0400 | |
---|---|---|
committer | 2017-07-20 14:57:35 -0400 | |
commit | 053aa4a8339c4f271f9f667e637b8c7f015cb95b (patch) | |
tree | 062daf76a79de3a057d3e0a0751bd97b23a9fa9f /drivers/media/dvb-frontends/s5h1420.c | |
parent | media: dib7000p: constify i2c_algorithm structure (diff) | |
download | linux-053aa4a8339c4f271f9f667e637b8c7f015cb95b.tar.gz linux-053aa4a8339c4f271f9f667e637b8c7f015cb95b.tar.bz2 linux-053aa4a8339c4f271f9f667e637b8c7f015cb95b.zip |
media: s5h1420: constify i2c_algorithm structure
Check for i2c_algorithm structures that are only stored in
the algo field of an i2c_adapter structure. This field is
declared const, so i2c_algorithm structures that have this
property can be declared as const also.
This issue was identified using Coccinelle and the following
semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct i2c_algorithm i@p = { ... };
@ok@
identifier r.i;
struct i2c_adapter e;
position p;
@@
e.algo = &i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct i2c_algorithm i = { ... };
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/dvb-frontends/s5h1420.c')
-rw-r--r-- | drivers/media/dvb-frontends/s5h1420.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/dvb-frontends/s5h1420.c b/drivers/media/dvb-frontends/s5h1420.c index cba9bff05b12..fd427a29c001 100644 --- a/drivers/media/dvb-frontends/s5h1420.c +++ b/drivers/media/dvb-frontends/s5h1420.c @@ -864,7 +864,7 @@ static int s5h1420_tuner_i2c_tuner_xfer(struct i2c_adapter *i2c_adap, struct i2c return i2c_transfer(state->i2c, m, 1 + num) == 1 + num ? num : -EIO; } -static struct i2c_algorithm s5h1420_tuner_i2c_algo = { +static const struct i2c_algorithm s5h1420_tuner_i2c_algo = { .master_xfer = s5h1420_tuner_i2c_tuner_xfer, .functionality = s5h1420_tuner_i2c_func, }; |