aboutsummaryrefslogtreecommitdiff
path: root/drivers/media/platform/sunxi
diff options
context:
space:
mode:
authorGravatar Paul Kocialkowski <paul.kocialkowski@bootlin.com> 2022-12-08 15:19:59 +0100
committerGravatar Hans Verkuil <hverkuil-cisco@xs4all.nl> 2022-12-12 11:36:00 +0100
commit1607a95c0d81842ff3db8df9543a9bb5492d480a (patch)
tree4c0825f08062079da0c16e374354080bbf7b217d /drivers/media/platform/sunxi
parentmedia: sun6i-csi: capture: Remove useless ret initialization (diff)
downloadlinux-1607a95c0d81842ff3db8df9543a9bb5492d480a.tar.gz
linux-1607a95c0d81842ff3db8df9543a9bb5492d480a.tar.bz2
linux-1607a95c0d81842ff3db8df9543a9bb5492d480a.zip
media: sun6i-mipi-csi2: Clarify return code handling in stream off path
Explicitly set ret to zero instead of assigning it and overwriting it later, which is a bit confusing to understand. Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Diffstat (limited to 'drivers/media/platform/sunxi')
-rw-r--r--drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c
index 484ac5f054d5..a220ce849b41 100644
--- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c
+++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c
@@ -188,7 +188,8 @@ static int sun6i_mipi_csi2_s_stream(struct v4l2_subdev *subdev, int on)
return -ENODEV;
if (!on) {
- ret = v4l2_subdev_call(source_subdev, video, s_stream, 0);
+ v4l2_subdev_call(source_subdev, video, s_stream, 0);
+ ret = 0;
goto disable;
}
@@ -280,8 +281,6 @@ static int sun6i_mipi_csi2_s_stream(struct v4l2_subdev *subdev, int on)
return 0;
disable:
- if (!on)
- ret = 0;
phy_power_off(dphy);
sun6i_mipi_csi2_disable(csi2_dev);