diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2023-03-26 16:31:45 +0200 |
|---|---|---|
| committer |  Hans Verkuil <hverkuil-cisco@xs4all.nl>
| 2023-04-11 16:59:18 +0200 |
| commit | a72b9869ece50cdd258c122b5ba403ae66a17d7f (patch) | |
| tree | 54524b0bdfcd11098817fe393aa8b9a0dbe4cd96 /drivers/media/platform/sunxi | |
| parent | media: stm32-dcmi: Convert to platform remove callback returning void (diff) | |
| download | linux-a72b9869ece50cdd258c122b5ba403ae66a17d7f.tar.gz linux-a72b9869ece50cdd258c122b5ba403ae66a17d7f.tar.bz2 linux-a72b9869ece50cdd258c122b5ba403ae66a17d7f.zip | |
media: sun4i_csi: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Diffstat (limited to 'drivers/media/platform/sunxi')
| -rw-r--r-- | drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c index 86c5235a0c7a..d6e7d1b36083 100644 --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c @@ -260,7 +260,7 @@ err_clean_pad: return ret; } -static int sun4i_csi_remove(struct platform_device *pdev) +static void sun4i_csi_remove(struct platform_device *pdev) { struct sun4i_csi *csi = platform_get_drvdata(pdev); @@ -271,8 +271,6 @@ static int sun4i_csi_remove(struct platform_device *pdev) media_device_unregister(&csi->mdev); sun4i_csi_dma_unregister(csi); media_device_cleanup(&csi->mdev); - - return 0; } static const struct sun4i_csi_traits sun4i_a10_csi1_traits = { @@ -330,7 +328,7 @@ static const struct dev_pm_ops sun4i_csi_pm_ops = { static struct platform_driver sun4i_csi_driver = { .probe = sun4i_csi_probe, - .remove = sun4i_csi_remove, + .remove_new = sun4i_csi_remove, .driver = { .name = "sun4i-csi", .of_match_table = sun4i_csi_of_match, |