diff options
| author |  Ricardo Ribalda <ribalda@chromium.org>
| 2024-04-29 16:04:43 +0100 |
|---|---|---|
| committer |  Mauro Carvalho Chehab <mchehab@kernel.org>
| 2024-05-03 11:06:06 +0100 |
| commit | 9a6f13261d9b2e49342acea70888aaffc9eede19 (patch) | |
| tree | 8e8fa40149617845ba26b75e467bfa288c7d714a /drivers/media | |
| parent | media: stb0899: Simplify check (diff) | |
| download | linux-9a6f13261d9b2e49342acea70888aaffc9eede19.tar.gz linux-9a6f13261d9b2e49342acea70888aaffc9eede19.tar.bz2 linux-9a6f13261d9b2e49342acea70888aaffc9eede19.zip | |
media: uvcvideo: Use max() macro
It makes the code slightly more clear and makes cocci incredibly happy:
drivers/media/usb/uvc/uvc_ctrl.c:839:22-23: WARNING opportunity for max()
Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-4-3c4865f5a4b0@chromium.org
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/media')
| -rw-r--r-- | drivers/media/usb/uvc/uvc_ctrl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index e59a463c2761..f8ae14b8b426 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -836,7 +836,7 @@ static s32 uvc_get_le_value(struct uvc_control_mapping *mapping, while (1) { u8 byte = *data & mask; value |= offset > 0 ? (byte >> offset) : (byte << (-offset)); - bits -= 8 - (offset > 0 ? offset : 0); + bits -= 8 - max(offset, 0); if (bits <= 0) break; |