aboutsummaryrefslogtreecommitdiff
path: root/drivers/mmc/host
diff options
context:
space:
mode:
authorGravatar Yangtao Li <frank.li@vivo.com> 2023-07-27 15:00:32 +0800
committerGravatar Ulf Hansson <ulf.hansson@linaro.org> 2023-08-15 12:45:06 +0200
commitf9b85b78656b5c132066d24690de2ff5c72e5b90 (patch)
treef3eb386040c6e33825f37a9287aef4cb6449adf0 /drivers/mmc/host
parentmmc: owl: Convert to platform remove callback returning void (diff)
downloadlinux-f9b85b78656b5c132066d24690de2ff5c72e5b90.tar.gz
linux-f9b85b78656b5c132066d24690de2ff5c72e5b90.tar.bz2
linux-f9b85b78656b5c132066d24690de2ff5c72e5b90.zip
mmc: wbsd: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Yangtao Li <frank.li@vivo.com> Link: https://lore.kernel.org/r/20230727070051.17778-43-frank.li@vivo.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc/host')
-rw-r--r--drivers/mmc/host/wbsd.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
index 0589d169e8fb..001a468bc149 100644
--- a/drivers/mmc/host/wbsd.c
+++ b/drivers/mmc/host/wbsd.c
@@ -1754,11 +1754,9 @@ static int wbsd_probe(struct platform_device *dev)
return wbsd_init(&dev->dev, param_io, param_irq, param_dma, 0);
}
-static int wbsd_remove(struct platform_device *dev)
+static void wbsd_remove(struct platform_device *dev)
{
wbsd_shutdown(&dev->dev, 0);
-
- return 0;
}
/*
@@ -1900,8 +1898,7 @@ static struct platform_device *wbsd_device;
static struct platform_driver wbsd_driver = {
.probe = wbsd_probe,
- .remove = wbsd_remove,
-
+ .remove_new = wbsd_remove,
.suspend = wbsd_platform_suspend,
.resume = wbsd_platform_resume,
.driver = {