aboutsummaryrefslogtreecommitdiff
path: root/drivers/net/e1000e/netdev.c
diff options
context:
space:
mode:
authorGravatar Bruce Allan <bruce.w.allan@intel.com> 2011-01-06 14:29:48 +0000
committerGravatar David S. Miller <davem@davemloft.net> 2011-01-09 23:44:06 -0800
commitdd93f95e92283498f2497a632a81c167444668b5 (patch)
treefa5067184bc32c77bec6931a5a9862d8d137c270 /drivers/net/e1000e/netdev.c
parentnet offloading: Convert checksums to use centrally computed features. (diff)
downloadlinux-dd93f95e92283498f2497a632a81c167444668b5.tar.gz
linux-dd93f95e92283498f2497a632a81c167444668b5.tar.bz2
linux-dd93f95e92283498f2497a632a81c167444668b5.zip
e1000e: cleanup variables set but not used
The ICR register is clear on read and we don't care what the returned value is when resetting the hardware so the icr variable(s) can be removed. We should not ignore the return from e1000_lv_jumbo_workaround_ich8lan() and from e1000_get_phy_id_82571() (dump a debug message when it fails and when an unknown Phy id is returned). Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Tested-by: Emil Tantilov <emil.s.tantilov@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/e1000e/netdev.c')
-rw-r--r--drivers/net/e1000e/netdev.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index fe50242aa9e6..5498689ac20c 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -2734,6 +2734,9 @@ static void e1000_setup_rctl(struct e1000_adapter *adapter)
ret_val = e1000_lv_jumbo_workaround_ich8lan(hw, true);
else
ret_val = e1000_lv_jumbo_workaround_ich8lan(hw, false);
+
+ if (ret_val)
+ e_dbg("failed to enable jumbo frame workaround mode\n");
}
/* Program MC offset vector base */