diff options
| author |  Gencen Gan <gangecen@hust.edu.cn>
| 2023-04-24 23:28:01 +0800 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2023-04-25 09:41:18 +0100 |
| commit | d325c34d9e7e38d371c0a299d415e9b07f66a1fb (patch) | |
| tree | d63db238006d8d738433d538dbcb7de84a80fb6e /drivers/net/ethernet/amd | |
| parent | netlink: Use copy_to_user() for optval in netlink_getsockopt(). (diff) | |
| download | linux-d325c34d9e7e38d371c0a299d415e9b07f66a1fb.tar.gz linux-d325c34d9e7e38d371c0a299d415e9b07f66a1fb.tar.bz2 linux-d325c34d9e7e38d371c0a299d415e9b07f66a1fb.zip | |
net: amd: Fix link leak when verifying config failed
After failing to verify configuration, it returns directly without
releasing link, which may cause memory leak.
Paolo Abeni thinks that the whole code of this driver is quite
"suboptimal" and looks unmainatained since at least ~15y, so he
suggests that we could simply remove the whole driver, please
take it into consideration.
Simon Horman suggests that the fix label should be set to
"Linux-2.6.12-rc2" considering that the problem has existed
since the driver was introduced and the commit above doesn't
seem to exist in net/net-next.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Gan Gecen <gangecen@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/amd')
| -rw-r--r-- | drivers/net/ethernet/amd/nmclan_cs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c index 823a329a921f..0dd391c84c13 100644 --- a/drivers/net/ethernet/amd/nmclan_cs.c +++ b/drivers/net/ethernet/amd/nmclan_cs.c @@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link) } else { pr_notice("mace id not found: %x %x should be 0x40 0x?9\n", sig[0], sig[1]); - return -ENODEV; + goto failed; } } |