diff options
author | 2022-11-23 16:22:36 +0800 | |
---|---|---|
committer | 2022-11-24 10:15:47 +0100 | |
commit | 661e5ebbafd26d9d2e3c749f5cf591e55c7364f5 (patch) | |
tree | 21e9821d8d1532afde727ce41fe528ae70b7e4d7 /drivers/net/ethernet/cavium | |
parent | octeontx2-af: Fix reference count issue in rvu_sdp_init() (diff) | |
download | linux-661e5ebbafd26d9d2e3c749f5cf591e55c7364f5.tar.gz linux-661e5ebbafd26d9d2e3c749f5cf591e55c7364f5.tar.bz2 linux-661e5ebbafd26d9d2e3c749f5cf591e55c7364f5.zip |
net: thunderx: Fix the ACPI memory leak
The ACPI buffer memory (string.pointer) should be freed as the buffer is
not used after returning from bgx_acpi_match_id(), free it to prevent
memory leak.
Fixes: 46b903a01c05 ("net, thunder, bgx: Add support to get MAC address from ACPI.")
Signed-off-by: Yu Liao <liaoyu15@huawei.com>
Link: https://lore.kernel.org/r/20221123082237.1220521-1-liaoyu15@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/ethernet/cavium')
-rw-r--r-- | drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index 2f6484dc186a..7eb2ddbe9bad 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -1436,8 +1436,10 @@ static acpi_status bgx_acpi_match_id(acpi_handle handle, u32 lvl, return AE_OK; } - if (strncmp(string.pointer, bgx_sel, 4)) + if (strncmp(string.pointer, bgx_sel, 4)) { + kfree(string.pointer); return AE_OK; + } acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1, bgx_acpi_register_phy, NULL, bgx, NULL); |