diff options
| author |  Vadim Pasternak <vadimp@nvidia.com>
| 2023-08-24 15:43:08 +0200 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2023-08-25 10:53:37 +0100 |
| commit | 146c7c330507c0384bf29d567186632bfe975927 (patch) | |
| tree | 211d3a8f004e78cc9d5205c465759c78b90c4142 /drivers/net/ethernet/mellanox/mlxsw | |
| parent | net: arcnet: Do not call kfree_skb() under local_irq_disable() (diff) | |
| download | linux-146c7c330507c0384bf29d567186632bfe975927.tar.gz linux-146c7c330507c0384bf29d567186632bfe975927.tar.bz2 linux-146c7c330507c0384bf29d567186632bfe975927.zip | |
mlxsw: i2c: Fix chunk size setting in output mailbox buffer
The driver reads commands output from the output mailbox. If the size
of the output mailbox is not a multiple of the transaction /
block size, then the driver will not issue enough read transactions
to read the entire output, which can result in driver initialization
errors.
Fix by determining the number of transactions using DIV_ROUND_UP().
Fixes: 3029a693beda ("mlxsw: i2c: Allow flexible setting of I2C transactions size")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlxsw')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/i2c.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/i2c.c b/drivers/net/ethernet/mellanox/mlxsw/i2c.c index 41298835a11e..47af7ef7e4ee 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/i2c.c +++ b/drivers/net/ethernet/mellanox/mlxsw/i2c.c @@ -444,7 +444,7 @@ mlxsw_i2c_cmd(struct device *dev, u16 opcode, u32 in_mod, size_t in_mbox_size, } else { /* No input mailbox is case of initialization query command. */ reg_size = MLXSW_I2C_MAX_DATA_SIZE; - num = reg_size / mlxsw_i2c->block_size; + num = DIV_ROUND_UP(reg_size, mlxsw_i2c->block_size); if (mutex_lock_interruptible(&mlxsw_i2c->cmd.lock) < 0) { dev_err(&client->dev, "Could not acquire lock"); |