diff options
| author |  Heiner Kallweit <hkallweit1@gmail.com>
| 2023-03-06 22:25:49 +0100 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2023-03-08 09:30:41 +0000 |
| commit | 49ef7d846d4bd77b0b9f1f801fc765b004690a07 (patch) | |
| tree | 9cc4a1fc24dc558b0a83a937d5bbf8b3fdf74849 /drivers/net/ethernet/realtek | |
| parent | r8169: enable cfg9346 config register access in atomic context (diff) | |
| download | linux-49ef7d846d4bd77b0b9f1f801fc765b004690a07.tar.gz linux-49ef7d846d4bd77b0b9f1f801fc765b004690a07.tar.bz2 linux-49ef7d846d4bd77b0b9f1f801fc765b004690a07.zip | |
r8169: prepare rtl_hw_aspm_clkreq_enable for usage in atomic context
Bail out if the function is used with chip versions that don't support
ASPM configuration. In addition remove the delay, it tuned out that
it's not needed, also vendor driver r8125 doesn't have it.
Suggested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Tested-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/realtek')
| -rw-r--r-- | drivers/net/ethernet/realtek/r8169_main.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 61cbf498fd07..96af31aeab0a 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -2741,6 +2741,9 @@ static void rtl_disable_exit_l1(struct rtl8169_private *tp) static void rtl_hw_aspm_clkreq_enable(struct rtl8169_private *tp, bool enable) { + if (tp->mac_version < RTL_GIGA_MAC_VER_32) + return; + /* Don't enable ASPM in the chip if OS can't control ASPM */ if (enable && tp->aspm_manageable) { rtl_mod_config5(tp, 0, ASPM_en); @@ -2770,8 +2773,6 @@ static void rtl_hw_aspm_clkreq_enable(struct rtl8169_private *tp, bool enable) rtl_mod_config2(tp, ClkReqEn, 0); rtl_mod_config5(tp, ASPM_en, 0); } - - udelay(10); } static void rtl_set_fifo_size(struct rtl8169_private *tp, u16 rx_stat, |