diff options
| author |  Subbaraya Sundeep <sbhatta@marvell.com>
| 2023-11-29 11:11:48 +0530 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2023-12-01 12:19:02 +0000 |
| commit | 830139e7b6911266a84a77e1f18abf758995cc89 (patch) | |
| tree | a17183da3c42e465e99a7282897c2d28e8b62514 /drivers/net/ethernet | |
| parent | octeontx2-pf: Add missing mutex lock in otx2_get_pauseparam (diff) | |
| download | linux-830139e7b6911266a84a77e1f18abf758995cc89.tar.gz linux-830139e7b6911266a84a77e1f18abf758995cc89.tar.bz2 linux-830139e7b6911266a84a77e1f18abf758995cc89.zip | |
octeontx2-af: Check return value of nix_get_nixlf before using nixlf
If a NIXLF is not attached to a PF/VF device then
nix_get_nixlf function fails and returns proper error
code. But npc_get_default_entry_action does not check it
and uses garbage value in subsequent calls. Fix this
by cheking the return value of nix_get_nixlf.
Fixes: 967db3529eca ("octeontx2-af: add support for multicast/promisc packet replication feature")
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c index 16cfc802e348..f65805860c8d 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c @@ -389,7 +389,13 @@ static u64 npc_get_default_entry_action(struct rvu *rvu, struct npc_mcam *mcam, int bank, nixlf, index; /* get ucast entry rule entry index */ - nix_get_nixlf(rvu, pf_func, &nixlf, NULL); + if (nix_get_nixlf(rvu, pf_func, &nixlf, NULL)) { + dev_err(rvu->dev, "%s: nixlf not attached to pcifunc:0x%x\n", + __func__, pf_func); + /* Action 0 is drop */ + return 0; + } + index = npc_get_nixlf_mcam_index(mcam, pf_func, nixlf, NIXLF_UCAST_ENTRY); bank = npc_get_bank(mcam, index); |