aboutsummaryrefslogtreecommitdiff
path: root/drivers/net/ipa/gsi_reg.h
diff options
context:
space:
mode:
authorGravatar Alex Elder <elder@linaro.org> 2023-02-15 13:53:48 -0600
committerGravatar Paolo Abeni <pabeni@redhat.com> 2023-02-20 08:14:20 +0100
commit59b12b1d27f3f82e56462f0da6413e1849a06d3a (patch)
tree8364fb7dfcfba693c0dc9911bb04346c93134228 /drivers/net/ipa/gsi_reg.h
parentnet: ipa: fix an incorrect assignment (diff)
downloadlinux-59b12b1d27f3f82e56462f0da6413e1849a06d3a.tar.gz
linux-59b12b1d27f3f82e56462f0da6413e1849a06d3a.tar.bz2
linux-59b12b1d27f3f82e56462f0da6413e1849a06d3a.zip
net: ipa: kill gsi->virt_raw
Starting at IPA v4.5, almost all GSI registers had their offsets changed by a fixed amount (shifted downward by 0xd000). Rather than defining offsets for all those registers dependent on version, an adjustment was applied for most register accesses. This was implemented in commit cdeee49f3ef7f ("net: ipa: adjust GSI register addresses"). It was later modified to be a bit more obvious about the adjusment, in commit 571b1e7e58ad3 ("net: ipa: use a separate pointer for adjusted GSI memory"). We now are able to define every GSI register with its own offset, so there's no need to implement this special adjustment. So get rid of the "virt_raw" pointer, and just maintain "virt" as the (non-adjusted) base address of I/O mapped GSI register memory. Redefine the offsets of all GSI registers (other than the INTER_EE ones, which were not subject to the adjustment) for IPA v4.5+, subtracting 0xd000 from their defined offsets instead. Move the ERROR_LOG and ERROR_LOG_CLR definitions further down in the register definition files so all registers are defined in order of their offset. Signed-off-by: Alex Elder <elder@linaro.org> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/ipa/gsi_reg.h')
-rw-r--r--drivers/net/ipa/gsi_reg.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ipa/gsi_reg.h b/drivers/net/ipa/gsi_reg.h
index 5eda4def7ac4..e85765002aa4 100644
--- a/drivers/net/ipa/gsi_reg.h
+++ b/drivers/net/ipa/gsi_reg.h
@@ -351,8 +351,7 @@ const struct reg *gsi_reg(struct gsi *gsi, enum gsi_reg_id reg_id);
* @pdev: GSI (IPA) platform device
*
* Initialize GSI registers, including looking up and I/O mapping
- * the "gsi" memory space. This function sets gsi->virt_raw and
- * gsi->virt.
+ * the "gsi" memory space.
*/
int gsi_reg_init(struct gsi *gsi, struct platform_device *pdev);