diff options
| author |  Aminuddin Jamaluddin <aminuddin.jamaluddin@intel.com>
| 2022-11-14 14:53:02 +0800 |
|---|---|---|
| committer |  Paolo Abeni <pabeni@redhat.com>
| 2022-11-15 13:14:46 +0100 |
| commit | 18c532e44939caa17f1fa380f7ac50dbc0718dbb (patch) | |
| tree | 965ef55fe1b552d79cfe9452c476786763b5b00b /drivers/net/phy/marvell.c | |
| parent | net: ena: Fix error handling in ena_init() (diff) | |
| download | linux-18c532e44939caa17f1fa380f7ac50dbc0718dbb.tar.gz linux-18c532e44939caa17f1fa380f7ac50dbc0718dbb.tar.bz2 linux-18c532e44939caa17f1fa380f7ac50dbc0718dbb.zip | |
net: phy: marvell: add sleep time after enabling the loopback bit
Sleep time is added to ensure the phy to be ready after loopback
bit was set. This to prevent the phy loopback test from failing.
Fixes: 020a45aff119 ("net: phy: marvell: add Marvell specific PHY loopback")
Cc: <stable@vger.kernel.org> # 5.15.x
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Signed-off-by: Aminuddin Jamaluddin <aminuddin.jamaluddin@intel.com>
Link: https://lore.kernel.org/r/20221114065302.10625-1-aminuddin.jamaluddin@intel.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/phy/marvell.c')
| -rw-r--r-- | drivers/net/phy/marvell.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 2810f4f9da0c..0d706ee266af 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -2015,14 +2015,16 @@ static int m88e1510_loopback(struct phy_device *phydev, bool enable) if (err < 0) return err; - /* FIXME: Based on trial and error test, it seem 1G need to have - * delay between soft reset and loopback enablement. - */ - if (phydev->speed == SPEED_1000) - msleep(1000); + err = phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, + BMCR_LOOPBACK); - return phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, - BMCR_LOOPBACK); + if (!err) { + /* It takes some time for PHY device to switch + * into/out-of loopback mode. + */ + msleep(1000); + } + return err; } else { err = phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, 0); if (err < 0) |