diff options
| author |  Peter Kosyh <pkosyh@yandex.ru>
| 2022-11-17 18:28:06 +0300 |
|---|---|---|
| committer |  Jakub Kicinski <kuba@kernel.org>
| 2022-11-18 19:34:30 -0800 |
| commit | 594c61ffc77de0a197934aa0f1df9285c68801c6 (patch) | |
| tree | 558ed9fe599cd961985037d57bf1f9dde12f64cc /drivers/net | |
| parent | net: ethernet: mtk_eth_soc: fix error handling in mtk_open() (diff) | |
| download | linux-594c61ffc77de0a197934aa0f1df9285c68801c6.tar.gz linux-594c61ffc77de0a197934aa0f1df9285c68801c6.tar.bz2 linux-594c61ffc77de0a197934aa0f1df9285c68801c6.zip | |
net/mlx4: Check retval of mlx4_bitmap_init
If mlx4_bitmap_init fails, mlx4_bitmap_alloc_range will dereference
the NULL pointer (bitmap->table).
Make sure, that mlx4_bitmap_alloc_range called in no error case.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: d57febe1a478 ("net/mlx4: Add A0 hybrid steering")
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Peter Kosyh <pkosyh@yandex.ru>
Link: https://lore.kernel.org/r/20221117152806.278072-1-pkosyh@yandex.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/qp.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers/net/ethernet/mellanox/mlx4/qp.c index b149e601f673..48cfaa7eaf50 100644 --- a/drivers/net/ethernet/mellanox/mlx4/qp.c +++ b/drivers/net/ethernet/mellanox/mlx4/qp.c @@ -697,7 +697,8 @@ static int mlx4_create_zones(struct mlx4_dev *dev, err = mlx4_bitmap_init(*bitmap + k, 1, MLX4_QP_TABLE_RAW_ETH_SIZE - 1, 0, 0); - mlx4_bitmap_alloc_range(*bitmap + k, 1, 1, 0); + if (!err) + mlx4_bitmap_alloc_range(*bitmap + k, 1, 1, 0); } if (err) |