diff options
author | 2020-04-02 00:27:36 +0100 | |
---|---|---|
committer | 2020-04-02 06:50:59 -0700 | |
commit | 86287543715ac2a6d92d561cc105d79306511457 (patch) | |
tree | efa076f316c8d71ea51c3012fc00da41c2afc6d0 /drivers/net | |
parent | net: qualcomm: rmnet: Allow configuration updates to existing devices (diff) | |
download | linux-86287543715ac2a6d92d561cc105d79306511457.tar.gz linux-86287543715ac2a6d92d561cc105d79306511457.tar.bz2 linux-86287543715ac2a6d92d561cc105d79306511457.zip |
net: atlantic: fix missing | operator when assigning rec->llc
rec->llc is currently being assigned twice, once with the lower 8 bits
from packed_record[8] and then re-assigned afterwards with data from
packed_record[9]. This looks like a type, I believe the second assignment
should be using the |= operator rather than a direct assignment.
Addresses-Coverity: ("Unused value")
Fixes: b8f8a0b7b5cb ("net: atlantic: MACSec ingress offload HW bindings")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Igor Russkikh <irusskikh@marell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/macsec/macsec_api.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/macsec/macsec_api.c b/drivers/net/ethernet/aquantia/atlantic/macsec/macsec_api.c index 97901c114bfa..fbe9d88b13c7 100644 --- a/drivers/net/ethernet/aquantia/atlantic/macsec/macsec_api.c +++ b/drivers/net/ethernet/aquantia/atlantic/macsec/macsec_api.c @@ -491,7 +491,7 @@ get_ingress_preclass_record(struct aq_hw_s *hw, rec->snap[1] = packed_record[8] & 0xFF; rec->llc = (packed_record[8] >> 8) & 0xFF; - rec->llc = packed_record[9] << 8; + rec->llc |= packed_record[9] << 8; rec->mac_sa[0] = packed_record[10]; rec->mac_sa[0] |= packed_record[11] << 16; |