diff options
| author |  Caleb Sander <csander@purestorage.com>
| 2024-01-31 09:43:14 -0700 |
|---|---|---|
| committer |  Keith Busch <kbusch@kernel.org>
| 2024-01-31 17:00:45 -0800 |
| commit | 7d23e836b00eec96610141549f59e5902dc55fe8 (patch) | |
| tree | 14e53192e3d2d02a83ae6ba2b9b45916efcbab7f /drivers/nvme/host/pci.c | |
| parent | nvme: take const cmd pointer in read-only helpers (diff) | |
| download | linux-7d23e836b00eec96610141549f59e5902dc55fe8.tar.gz linux-7d23e836b00eec96610141549f59e5902dc55fe8.tar.bz2 linux-7d23e836b00eec96610141549f59e5902dc55fe8.zip | |
nvme: split out fabrics version of nvme_opcode_str()
nvme_opcode_str() currently supports admin, IO, and fabrics commands.
However, fabrics commands aren't allowed for the pci transport.
Currently the pci caller passes 0 as the fctype,
which means any fabrics command would be displayed as "Property Set".
Move fabrics command support into a function nvme_fabrics_opcode_str()
and remove the fctype argument to nvme_opcode_str().
This way, a fabrics command will display as "Unknown" for pci.
Convert the rdma and tcp transports to use nvme_fabrics_opcode_str().
Signed-off-by: Caleb Sander <csander@purestorage.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Diffstat (limited to 'drivers/nvme/host/pci.c')
| -rw-r--r-- | drivers/nvme/host/pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 25eb72779541..e6267a6aa380 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1349,7 +1349,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req) dev_warn(dev->ctrl.device, "I/O tag %d (%04x) opcode %#x (%s) QID %d timeout, reset controller\n", req->tag, nvme_cid(req), opcode, - nvme_opcode_str(nvmeq->qid, opcode, 0), nvmeq->qid); + nvme_opcode_str(nvmeq->qid, opcode), nvmeq->qid); nvme_req(req)->flags |= NVME_REQ_CANCELLED; goto disable; } |