diff options
| author |  Maurizio Lombardi <mlombard@redhat.com>
| 2022-08-29 14:40:30 +0200 |
|---|---|---|
| committer |  Christoph Hellwig <hch@lst.de>
| 2022-08-31 07:58:10 +0300 |
| commit | 478814a5584197fa1fb18377653626e3416e7cd6 (patch) | |
| tree | efaf903197c3da8917995066047ce0c45ebaf3f1 /drivers/nvme | |
| parent | nvmet-auth: add missing goto in nvmet_setup_auth() (diff) | |
| download | linux-478814a5584197fa1fb18377653626e3416e7cd6.tar.gz linux-478814a5584197fa1fb18377653626e3416e7cd6.tar.bz2 linux-478814a5584197fa1fb18377653626e3416e7cd6.zip | |
nvmet-tcp: fix unhandled tcp states in nvmet_tcp_state_change()
TCP_FIN_WAIT2 and TCP_LAST_ACK were not handled, the connection is closing
so we can ignore them and avoid printing the "unhandled state"
warning message.
[ 1298.852386] nvmet_tcp: queue 2 unhandled state 5
[ 1298.879112] nvmet_tcp: queue 7 unhandled state 5
[ 1298.884253] nvmet_tcp: queue 8 unhandled state 5
[ 1298.889475] nvmet_tcp: queue 9 unhandled state 5
v2: Do not call nvmet_tcp_schedule_release_queue(), just ignore
the fin_wait2 and last_ack states.
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/target/tcp.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index dc3b4dc8fe08..a3694a32f6d5 100644 --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -1506,6 +1506,9 @@ static void nvmet_tcp_state_change(struct sock *sk) goto done; switch (sk->sk_state) { + case TCP_FIN_WAIT2: + case TCP_LAST_ACK: + break; case TCP_FIN_WAIT1: case TCP_CLOSE_WAIT: case TCP_CLOSE: |