aboutsummaryrefslogtreecommitdiff
path: root/drivers/parisc
diff options
context:
space:
mode:
authorGravatar Shang XiaoJing <shangxiaojing@huawei.com> 2022-11-17 10:45:14 +0800
committerGravatar Helge Deller <deller@gmx.de> 2022-12-17 23:19:38 +0100
commit41f563ab3c33698bdfc3403c7c2e6c94e73681e4 (patch)
tree709401d0bddad8e5890de63441371c067bdf594e /drivers/parisc
parentparisc: Fix inconsistent indenting in setup_cmdline() (diff)
downloadlinux-41f563ab3c33698bdfc3403c7c2e6c94e73681e4.tar.gz
linux-41f563ab3c33698bdfc3403c7c2e6c94e73681e4.tar.bz2
linux-41f563ab3c33698bdfc3403c7c2e6c94e73681e4.zip
parisc: led: Fix potential null-ptr-deref in start_task()
start_task() calls create_singlethread_workqueue() and not checked the ret value, which may return NULL. And a null-ptr-deref may happen: start_task() create_singlethread_workqueue() # failed, led_wq is NULL queue_delayed_work() queue_delayed_work_on() __queue_delayed_work() # warning here, but continue __queue_work() # access wq->flags, null-ptr-deref Check the ret value and return -ENOMEM if it is NULL. Fixes: 3499495205a6 ("[PARISC] Use work queue in LED/LCD driver instead of tasklet.") Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> Signed-off-by: Helge Deller <deller@gmx.de> Cc: <stable@vger.kernel.org>
Diffstat (limited to 'drivers/parisc')
-rw-r--r--drivers/parisc/led.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
index d4be9d2ee74d..8bdc5e043831 100644
--- a/drivers/parisc/led.c
+++ b/drivers/parisc/led.c
@@ -137,6 +137,9 @@ static int start_task(void)
/* Create the work queue and queue the LED task */
led_wq = create_singlethread_workqueue("led_wq");
+ if (!led_wq)
+ return -ENOMEM;
+
queue_delayed_work(led_wq, &led_task, 0);
return 0;