diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2023-10-01 19:02:54 +0200 |
|---|---|---|
| committer |  Bjorn Helgaas <bhelgaas@google.com>
| 2023-10-10 12:13:17 -0500 |
| commit | 7994db905c0fd692cf04c527585f08a91b560144 (patch) | |
| tree | 1b6cf47e0d0b248031031b5e2d3db899d71f0e0a /drivers/pci/quirks.c | |
| parent | PCI: keystone: Don't discard .remove() callback (diff) | |
| download | linux-7994db905c0fd692cf04c527585f08a91b560144.tar.gz linux-7994db905c0fd692cf04c527585f08a91b560144.tar.bz2 linux-7994db905c0fd692cf04c527585f08a91b560144.zip | |
PCI: keystone: Don't discard .probe() callback
The __init annotation makes the ks_pcie_probe() function disappear after
booting completes. However a device can also be bound later. In that case,
we try to call ks_pcie_probe(), but the backing memory is likely already
overwritten.
The right thing to do is do always have the probe callback available. Note
that the (wrong) __refdata annotation prevented this issue to be noticed by
modpost.
Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver")
Link: https://lore.kernel.org/r/20231001170254.2506508-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/pci/quirks.c')
0 files changed, 0 insertions, 0 deletions