diff options
| author |  Bjorn Helgaas <bhelgaas@google.com>
| 2024-05-16 18:14:10 -0500 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com>
| 2024-05-16 18:14:10 -0500 |
| commit | 58adb5e79c46f48248daaf9de8c9c4cb6dd96f9c (patch) | |
| tree | 9c68bb91845ccd2678547acc3f1e1f964f04370a /drivers/pci | |
| parent | Merge branch 'pci/enumeration' (diff) | |
| parent | PCI: hotplug: Remove obsolete sgi_hotplug TODO notes (diff) | |
| download | linux-58adb5e79c46f48248daaf9de8c9c4cb6dd96f9c.tar.gz linux-58adb5e79c46f48248daaf9de8c9c4cb6dd96f9c.tar.bz2 linux-58adb5e79c46f48248daaf9de8c9c4cb6dd96f9c.zip | |
Merge branch 'pci/hotplug'
- Update hotplug TODO notes (Nam Cao)
* pci/hotplug:
PCI: hotplug: Remove obsolete sgi_hotplug TODO notes
PCI: hotplug: Document unchecked return value of pci_hp_add_bridge()
Diffstat (limited to 'drivers/pci')
| -rw-r--r-- | drivers/pci/hotplug/TODO | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/drivers/pci/hotplug/TODO b/drivers/pci/hotplug/TODO index fdb8dd6ea24d..9d428b0ea524 100644 --- a/drivers/pci/hotplug/TODO +++ b/drivers/pci/hotplug/TODO @@ -6,6 +6,8 @@ cpcihp: ->set_power callbacks in struct cpci_hp_controller_ops. Why were they introduced? Can they be removed from the struct? +* Returned code from pci_hp_add_bridge() is not checked. + cpqphp: * The driver spawns a kthread cpqhp_event_thread() which is woken by the @@ -16,6 +18,8 @@ cpqphp: * A large portion of cpqphp_ctrl.c and cpqphp_pci.c concerns resource management. Doesn't this duplicate functionality in the core? +* Returned code from pci_hp_add_bridge() is not checked. + ibmphp: * Implementations of hotplug_slot_ops callbacks such as get_adapter_present() @@ -43,13 +47,7 @@ ibmphp: * A large portion of ibmphp_res.c and ibmphp_pci.c concerns resource management. Doesn't this duplicate functionality in the core? -sgi_hotplug: - -* Several functions access the pci_slot member in struct hotplug_slot even - though pci_hotplug.h declares it private. See sn_hp_destroy() for an - example. Either the pci_slot member should no longer be declared private - or sgi_hotplug should store a pointer to it in struct slot. Probably the - former. +* Returned code from pci_hp_add_bridge() is not checked. shpchp: |