diff options
| author |  Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
| 2024-04-23 16:08:20 +0300 |
|---|---|---|
| committer |  Bjorn Helgaas <bhelgaas@google.com>
| 2024-04-25 12:53:29 -0500 |
| commit | cdc6c4abcb313be1b7118b6e86eb99a85a626578 (patch) | |
| tree | 64cdaa992c9ef17b4eb84fc766877b1c88be1034 /drivers/pci | |
| parent | PCI: Wait for Link Training==0 before starting Link retrain (diff) | |
| download | linux-cdc6c4abcb313be1b7118b6e86eb99a85a626578.tar.gz linux-cdc6c4abcb313be1b7118b6e86eb99a85a626578.tar.bz2 linux-cdc6c4abcb313be1b7118b6e86eb99a85a626578.zip | |
PCI: Clarify intent of LT wait
Clarify the comment relating to the LT wait and the purpose of the check
that implements the implementation note in PCIe r6.1 sec 7.5.3.7.
Suggested-by: Maciej W. Rozycki <macro@orcam.me.uk>
Link: https://lore.kernel.org/r/20240423130820.43824-2-ilpo.jarvinen@linux.intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci')
| -rw-r--r-- | drivers/pci/pci.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 70b8c87055cb..5a25facb3ce7 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4625,9 +4625,10 @@ int pcie_retrain_link(struct pci_dev *pdev, bool use_lt) /* * Ensure the updated LNKCTL parameters are used during link - * training by checking that there is no ongoing link training to - * avoid LTSSM race as recommended in Implementation Note at the - * end of PCIe r6.0.1 sec 7.5.3.7. + * training by checking that there is no ongoing link training that + * may have started before link parameters were changed, so as to + * avoid LTSSM race as recommended in Implementation Note at the end + * of PCIe r6.1 sec 7.5.3.7. */ rc = pcie_wait_for_link_status(pdev, true, false); if (rc) |