diff options
| author |  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| 2023-03-07 12:58:32 +0100 |
|---|---|---|
| committer |  Vinod Koul <vkoul@kernel.org>
| 2023-03-20 18:14:56 +0530 |
| commit | 7b23fd5c835298a846f3f18dfdcfa95ef34172c4 (patch) | |
| tree | e70f8103da416479090ace65d13195089ef0fc5d /drivers/phy/cadence/cdns-dphy.c | |
| parent | phy: broadcom: phy-brcm-usb: Convert to platform remove callback returning void (diff) | |
| download | linux-7b23fd5c835298a846f3f18dfdcfa95ef34172c4.tar.gz linux-7b23fd5c835298a846f3f18dfdcfa95ef34172c4.tar.bz2 linux-7b23fd5c835298a846f3f18dfdcfa95ef34172c4.zip | |
phy: cadence: cdns-dphy: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/cadence/cdns-dphy.c')
| -rw-r--r-- | drivers/phy/cadence/cdns-dphy.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dphy.c index 3dfdfb33cd0a..6e58012b6488 100644 --- a/drivers/phy/cadence/cdns-dphy.c +++ b/drivers/phy/cadence/cdns-dphy.c @@ -456,14 +456,12 @@ static int cdns_dphy_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(phy_provider); } -static int cdns_dphy_remove(struct platform_device *pdev) +static void cdns_dphy_remove(struct platform_device *pdev) { struct cdns_dphy *dphy = dev_get_drvdata(&pdev->dev); if (dphy->ops->remove) dphy->ops->remove(dphy); - - return 0; } static const struct of_device_id cdns_dphy_of_match[] = { @@ -475,7 +473,7 @@ MODULE_DEVICE_TABLE(of, cdns_dphy_of_match); static struct platform_driver cdns_dphy_platform_driver = { .probe = cdns_dphy_probe, - .remove = cdns_dphy_remove, + .remove_new = cdns_dphy_remove, .driver = { .name = "cdns-mipi-dphy", .of_match_table = cdns_dphy_of_match, |