diff options
| author |  Siddharth Vadapalli <s-vadapalli@ti.com>
| 2023-04-03 15:15:52 +0530 |
|---|---|---|
| committer |  Vinod Koul <vkoul@kernel.org>
| 2023-04-12 22:07:01 +0530 |
| commit | 57c0e1362fdd57d0cea7ab1e583b58abf4bd8c2d (patch) | |
| tree | a131a7f8fc6b2bea5f4f4e0b4f74c488bfec8bd2 /drivers/phy/ti | |
| parent | phy: cadence: Sierra: Add PCIe + SGMII PHY multilink configuration (diff) | |
| download | linux-57c0e1362fdd57d0cea7ab1e583b58abf4bd8c2d.tar.gz linux-57c0e1362fdd57d0cea7ab1e583b58abf4bd8c2d.tar.bz2 linux-57c0e1362fdd57d0cea7ab1e583b58abf4bd8c2d.zip | |
phy: ti: j721e-wiz: Fix unreachable code in wiz_mode_select()
In the wiz_mode_select() function, the configuration performed for
PHY_TYPE_USXGMII is unreachable. Fix it.
Fixes: b64a85fb8f53 ("phy: ti: phy-j721e-wiz.c: Add usxgmii support in wiz driver")
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/20230403094552.929108-1-s-vadapalli@ti.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/ti')
| -rw-r--r-- | drivers/phy/ti/phy-j721e-wiz.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index d2fd2143450a..d59918457799 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -443,18 +443,17 @@ static int wiz_mode_select(struct wiz *wiz) int i; for (i = 0; i < num_lanes; i++) { - if (wiz->lane_phy_type[i] == PHY_TYPE_DP) + if (wiz->lane_phy_type[i] == PHY_TYPE_DP) { mode = LANE_MODE_GEN1; - else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII) + } else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII) { mode = LANE_MODE_GEN2; - else - continue; - - if (wiz->lane_phy_type[i] == PHY_TYPE_USXGMII) { + } else if (wiz->lane_phy_type[i] == PHY_TYPE_USXGMII) { ret = regmap_field_write(wiz->p0_mac_src_sel[i], 0x3); ret = regmap_field_write(wiz->p0_rxfclk_sel[i], 0x3); ret = regmap_field_write(wiz->p0_refclk_sel[i], 0x3); mode = LANE_MODE_GEN1; + } else { + continue; } ret = regmap_field_write(wiz->p_standard_mode[i], mode); |