diff options
| author |  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
| 2022-06-13 19:08:48 +0300 |
|---|---|---|
| committer |  Vinod Koul <vkoul@kernel.org>
| 2022-07-05 10:57:32 +0530 |
| commit | d4a0a189b72a7c98e4256292b18b67c69fbc9343 (patch) | |
| tree | 5b963b7bf02bc3f9926bad032cf33c83a530fd23 /drivers/phy/ti | |
| parent | MAINTAINERS: add include/dt-bindings/phy to GENERIC PHY FRAMEWORK (diff) | |
| download | linux-d4a0a189b72a7c98e4256292b18b67c69fbc9343.tar.gz linux-d4a0a189b72a7c98e4256292b18b67c69fbc9343.tar.bz2 linux-d4a0a189b72a7c98e4256292b18b67c69fbc9343.zip | |
phy: ti: tusb1210: Don't check for write errors when powering on
On some platforms, like Intel Merrifield, the writing values during power on
may timeout:
tusb1210 dwc3.0.auto.ulpi: error -110 writing val 0x41 to reg 0x80
phy phy-dwc3.0.auto.ulpi.0: phy poweron failed --> -110
dwc3 dwc3.0.auto: error -ETIMEDOUT: failed to initialize core
dwc3: probe of dwc3.0.auto failed with error -110
which effectively fails the probe of the USB controller.
Drop the check as it was before the culprit commit (see Fixes tag).
Fixes: 09a3512681b3 ("phy: ti: tusb1210: Improve ulpi_read()/_write() error checking")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Ferry Toth <fntoth@gmail.com>
Link: https://lore.kernel.org/r/20220613160848.82746-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/ti')
| -rw-r--r-- | drivers/phy/ti/phy-tusb1210.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/phy/ti/phy-tusb1210.c b/drivers/phy/ti/phy-tusb1210.c index c3ab4b69ea68..669c13d6e402 100644 --- a/drivers/phy/ti/phy-tusb1210.c +++ b/drivers/phy/ti/phy-tusb1210.c @@ -105,8 +105,9 @@ static int tusb1210_power_on(struct phy *phy) msleep(TUSB1210_RESET_TIME_MS); /* Restore the optional eye diagram optimization value */ - return tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2, - tusb->vendor_specific2); + tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2, tusb->vendor_specific2); + + return 0; } static int tusb1210_power_off(struct phy *phy) |