diff options
| author |  Claudiu Beznea <claudiu.beznea@microchip.com>
| 2023-06-15 13:53:32 +0300 |
|---|---|---|
| committer |  Linus Walleij <linus.walleij@linaro.org>
| 2023-06-16 15:01:45 +0200 |
| commit | 310cd4c206cd04696ccbfd1927b5ab6973e8cc8e (patch) | |
| tree | 2230eaecd620b278c549ed282211cdf45ee2906c /drivers/pinctrl/pinctrl-microchip-sgpio.c | |
| parent | pinctrl: freescale: Fix a memory out of bounds when num_configs is 1 (diff) | |
| download | linux-310cd4c206cd04696ccbfd1927b5ab6973e8cc8e.tar.gz linux-310cd4c206cd04696ccbfd1927b5ab6973e8cc8e.tar.bz2 linux-310cd4c206cd04696ccbfd1927b5ab6973e8cc8e.zip | |
pinctrl: microchip-sgpio: check return value of devm_kasprintf()
devm_kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).
Fixes: 7e5ea974e61c ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230615105333.585304-3-claudiu.beznea@microchip.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-microchip-sgpio.c')
| -rw-r--r-- | drivers/pinctrl/pinctrl-microchip-sgpio.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c index 59f232a68b5a..a60db93b61b1 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -816,6 +816,9 @@ static int microchip_sgpio_register_bank(struct device *dev, pctl_desc->name = devm_kasprintf(dev, GFP_KERNEL, "%s-%sput", dev_name(dev), bank->is_input ? "in" : "out"); + if (!pctl_desc->name) + return -ENOMEM; + pctl_desc->pctlops = &sgpio_pctl_ops; pctl_desc->pmxops = &sgpio_pmx_ops; pctl_desc->confops = &sgpio_confops; |